Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#10888 - Chiller minimum load ratio is set in the IDF however does not appear in eplustbl.htm for Chiller:Electric:EIR and Chiller:Electric:ReformulatedEIR #10915

Merged
merged 4 commits into from
Feb 5, 2025
Merged

#10888 - Chiller minimum load ratio is set in the IDF however does not appear in eplustbl.htm for Chiller:Electric:EIR and Chiller:Electric:ReformulatedEIR #10915

merged 4 commits into from
Feb 5, 2025

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Jan 28, 2025

Pull request overview

Description of the purpose of this PR

  • Chiller:Electric:EIR: Minimum part loat ratio was never reported (it was always zero)
  • Chiller:Electric:ReformulatedEIR: the Minimum Part Load Ratio reported was actually the EIRFPLR's Curve Minimum Input Value

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmarrec
Add tests for #10888
1bc219d 
```
[ RUN      ] EnergyPlusFixture.ChillerElectricEIR_OutputReport
/home/julien/Software/Others/EnergyPlus/tst/EnergyPlus/unit/ChillerElectricEIR.unit.cc:782: Failure
Expected equality of these values:
  "0.10"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchChillerMinPLR, ChillerName)
    Which is: "0.00"
/home/julien/Software/Others/EnergyPlus/tst/EnergyPlus/unit/ChillerElectricEIR.unit.cc:795: Failure
Expected equality of these values:
  "20.00"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchChillerDesSizeRefCHWFlowRate, ChillerName)
    Which is: "0.00"
/home/julien/Software/Others/EnergyPlus/tst/EnergyPlus/unit/ChillerElectricEIR.unit.cc:797: Failure
Expected equality of these values:
  "25.82"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchChillerDesSizeRefCondFluidFlowRate, ChillerName)
    Which is: "0.00"
[  FAILED  ] EnergyPlusFixture.ChillerElectricEIR_OutputReport (2297 ms)
[ RUN      ] EnergyPlusFixture.ChillerElectricReformulatedEIR_OutputReport
/home/julien/Software/Others/EnergyPlus/tst/EnergyPlus/unit/ChillerReformulatedEIR.unit.cc:453: Failure
Expected equality of these values:
  "0.10"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchChillerMinPLR, ChillerName)
    Which is: "0.02"
[  FAILED  ] EnergyPlusFixture.ChillerElectricReformulatedEIR_OutputReport (146 ms)
```
@jmarrec
Minor tweak, mostly for ChillerElectricEIR to correct set the mass fl…
442c05a 
…ow rate

```
[ RUN      ] EnergyPlusFixture.ChillerElectricEIR_OutputReport
/home/julien/Software/Others/EnergyPlus/tst/EnergyPlus/unit/ChillerElectricEIR.unit.cc:785: Failure
Expected equality of these values:
  "0.10"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchChillerMinPLR, ChillerName)
    Which is: "0.00"
[  FAILED  ] EnergyPlusFixture.ChillerElectricEIR_OutputReport (2242 ms)
[ RUN      ] EnergyPlusFixture.ChillerElectricReformulatedEIR_OutputReport
/home/julien/Software/Others/EnergyPlus/tst/EnergyPlus/unit/ChillerReformulatedEIR.unit.cc:457: Failure
Expected equality of these values:
  "0.10"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchChillerMinPLR, ChillerName)
    Which is: "0.02"
[  FAILED  ] EnergyPlusFixture.ChillerElectricReformulatedEIR_OutputReport (146 ms)

```
@jmarrec
FIx #10888 - MinPartLoadRatio for Chillers
3eb34cf
@jmarrec
Revert "Set Mass flow Rate"
eb331c0 
This reverts uneeded bits from commit 3eb34cf (discovered that if I trigger the unit test in the right order, and call initialize after a first size() call, the mass flow rates are properly set and reported)
@jmarrec jmarrec added the Defect Includes code to repair a defect in EnergyPlus label Jan 28, 2025
@jmarrec jmarrec self-assigned this Jan 28, 2025
@github-actions GitHub Actions
Copy link

⚠️ Regressions detected on macos-14 for commit 656f6a2

Regression Summary
  • Table Big Diffs: 41

Myoldmopar
Myoldmopar approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good here, will test locally.

src/EnergyPlus/ChillerElectricEIR.cc
@@ -1673,7 +1673,7 @@ void ElectricEIRChillerSpecs::size(EnergyPlusData &state)
this->CDPlantLoc.loopNum > 0
? state.dataPlnt->PlantLoop(this->CDPlantLoc.loopNum).LoopSide(this->CDPlantLoc.loopSideNum).Branch(this->CDPlantLoc.branchNum).Name
: "N/A");
OutputReportPredefined::PreDefTableEntry(state, state.dataOutRptPredefined->pdchChillerMinPLR, this->Name, this->ChillerEIRFPLRMin);
OutputReportPredefined::PreDefTableEntry(state, state.dataOutRptPredefined->pdchChillerMinPLR, this->Name, this->MinPartLoadRat);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, great little fix here.

@Myoldmopar
Copy link
Member

This works great with develop pulled in, thanks @jmarrec, merging.

@Myoldmopar Myoldmopar merged commit e44b85d into develop Feb 5, 2025
10 checks passed
@Myoldmopar Myoldmopar deleted the 10888_ChillerMinPLRReport branch February 5, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Myoldmopar Myoldmopar Myoldmopar approved these changes

Assignees

@jmarrec jmarrec

Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chiller minimum load ratio is set in the IDF however does not appear in eplustbl.htm
4 participants
@jmarrec @Myoldmopar @nrel-bot-2 @nrel-bot-2c